RFR: 8292679: Simplify thread creation in gtest and port 2 tests to new way

Coleen Phillimore coleenp at openjdk.org
Mon Aug 22 12:42:32 UTC 2022


On Mon, 22 Aug 2022 10:53:27 GMT, Johan Sjölén <duke at openjdk.org> wrote:

> This PR removes a lot of boilerplate that was required when creating multi-threaded tests and ports 2 tests to show that the number of lines of code is significantly reduced and that porting is fairly trivial. The ported tests also serve as an introduction to others who're looking into writing their own multi-threaded tests.
> 
> Testing: Ran the ported tests on my machine, also running the tests on x64 {Windows, Linux, Mac OS X],  aarch64 { Linux, Mac OS X} and tier1 for "completeness".

I like this change a lot!

test/hotspot/gtest/utilities/test_globalCounter.cpp line 64:

> 62:                                                                                     [&]() {
> 63:                                                                                       return &test;
> 64:                                                                                     });

Can you format the Symbol case like this?  makes it easier to parse the syntax and match the ()s.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9962


More information about the hotspot-dev mailing list