RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v2]

[Markus Grönlund]

On Mon, 11 Jul 2022 13:26:34 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> [JDK-8282420](https://bugs.openjdk.org/browse/JDK-8282420) introduced the notion of "blessed methods" which are those that can link against `jdk.jfr.internal.event.EventWriterFactory.getEventWriter(long)`.
>> This PR enhances the JVMCI ConstantPool API so that it can take a caller context when resolving a method to enforce this constraint properly.
>
> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   support special linkage rules for jdk.jfr.internal.event.EventWriterFactory.getEventWriter(long) in JVMCI

Hi Douglas, sorry for the delay in getting to this. The JFR-related changes look good. I can't really comment on the jvmci java classes in detail unfortunately but they look reasonable. Cheers.

test/jdk/jdk/jfr/jvm/TestGetEventWriter.java line 102:

> 100:     }
> 101: 
> 102:     private static ResolvedJavaMethod findCommitMethod(MetaAccessProvider metaAccess, Class<?> eventClass) {

Can you please move all the JVMCI support stuff to the end of the file instead of the beginning? Only because it makes for easier reading for the non-JVMCI cases, thanks.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9449