RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v2]

Markus Grönlund mgronlun at openjdk.org
Mon Aug 22 14:08:35 UTC 2022


On Mon, 11 Jul 2022 11:14:52 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   support special linkage rules for jdk.jfr.internal.event.EventWriterFactory.getEventWriter(long) in JVMCI
>
> test/jdk/jdk/jfr/jvm/TestGetEventWriter.java line 60:
> 
>> 58:  * @run main/othervm jdk.jfr.jvm.TestGetEventWriter
>> 59:  *
>> 60:  * @run main/othervm -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -Dtest.jvmci=true --add-exports=jdk.jfr/jdk.jfr.internal.event=ALL-UNNAMED
> 
> I think `--add-exports=jdk.jfr/jdk.jfr.internal.event=ALL-UNNAMED` should be added to all `@run` specs in this test. See more details [here](https://github.com/openjdk/jdk/pull/8383#discussion_r915755771).

We export certain modules and packages dynamically to the caller module when it registers an event. So don't think it is needed for those.

-------------

PR: https://git.openjdk.org/jdk/pull/9449


More information about the hotspot-dev mailing list