RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v3]
Markus Grönlund
mgronlun at openjdk.org
Mon Aug 22 16:00:46 UTC 2022
On Mon, 22 Aug 2022 15:01:19 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> We export certain modules and packages dynamically to the caller module when it registers an event. So don't think it is needed for those.
>
> Maybe I'm missing the point of these tests but I assume they are trying to exercise the blessed method checks in which case the IllegalAccessError message should be coming from here: https://github.com/openjdk/jdk/blob/master/src/hotspot/share/jfr/instrumentation/jfrResolution.cpp#L81
> Instead, it is coming from the module access checks.
> Please see more details at https://github.com/openjdk/jdk/pull/8383#discussion_r915755771
Now I understand better what you are referring to, thanks for noticing this. I think your suggestion is good, it makes sense to make the tests better targeted. Please also add the --add-exports to the other tests as well. Thanks again for seeing this.
-------------
PR: https://git.openjdk.org/jdk/pull/9449
More information about the hotspot-dev
mailing list