RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v3]

[Doug Simon]

On Mon, 22 Aug 2022 16:29:24 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Now I understand better what you are referring to, thanks for noticing this. I think your suggestion is good, it makes sense to make the tests better targeted. Please also add the --add-exports to the other tests as well. Thanks again for seeing this.
>
> I think we want to test what is being shipped. From the beginning there was --add-exports, but then it was removed and we found issues (unexpected exception). Maybe we can have both, but I think it would be unfortunate to not test the "full scenario" (which might include registering an event).

As far as I can see, without the `--add-exports`, all that is being tested is module access checks. Are there other tests specifically testing the access checks in [`JfrResolution::on_runtime_resolution`](https://github.com/openjdk/jdk/blob/aa9b8f04bf74d5fa00f2b27895e7369abea3a930/src/hotspot/share/jfr/instrumentation/jfrResolution.cpp#L55).
That said, I'm happy to leave the original tests in `TestGetEventWriter.java` as is.

-------------

PR: https://git.openjdk.org/jdk/pull/9449