RFR: 8292679: Simplify thread creation in gtest and port 2 tests to new way
Thomas Stuefe
stuefe at openjdk.org
Tue Aug 23 07:10:32 UTC 2022
On Mon, 22 Aug 2022 20:55:06 GMT, David Holmes <dholmes at openjdk.org> wrote:
> The experience of developers with templates and STL will vary widely - just something to bear in mind when modernising the codebase. :) I found it harder to "spot the threads" in the new style.
Over-templatizing stuff is as bad as not using templates where they make sense. One negative effect, not the only one: it makes builds take longer, which is a tax every developer has to pay many times over. Not long ago, JDK builds used to be done in ~2.5 minutes on my fast machine, and now I'm up to almost 4 minutes. This, too, is death by a thousand cuts.
Other effects include APIs that are harder to read since template parameters are often undocumented. IDEs have a harder time coping. And code may become harder to re-use since what should be runtime decisions get baked into the code in the form of template args.
-------------
PR: https://git.openjdk.org/jdk/pull/9962
More information about the hotspot-dev
mailing list