RFR: 8292194: G1 nmethod entry barrier disarm value wraps around too early

Erik Österlund eosterlund at openjdk.org
Wed Aug 24 13:11:27 UTC 2022


On Wed, 24 Aug 2022 11:31:33 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Let's say a rather rapid back to back concurrent full GC interval might be 10 ms ish. With such time intervals, it would take a bit over 16 years worth of being constantly interrupted and not finishing a single GC cycle, before any assumption would be broken. I wouldn't wish for anyone to be stuck in a single JVM for that long, hence why I think "something is seriously wrong" if that ever happened. I'm personally okay with that, and think we have bigger fish to fry. For example, the CollectedHeap::_total_collections counter is an unsigned int and there assumptions that it never wraps around. That sounds more likely to ever happen. Yet seemingly unlikely.
>
> :rofl:
> Just mentioning. Lgtm.

Thanks for the review, @tschatzl.

-------------

PR: https://git.openjdk.org/jdk/pull/9822


More information about the hotspot-dev mailing list