RFR: 8292891: ifdef-out some CDS-only functions

Calvin Cheung ccheung at openjdk.org
Thu Aug 25 00:04:20 UTC 2022


On Wed, 24 Aug 2022 22:27:48 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> Some CDS functions are always compiled, even when CDS is not enabled (e.g., for the minimal VM).
> 
> This RFE puts some of the obvious ones inside `#if INCLUDE_CDS` blocks. 
> 
> Note: my goal is not to make the minimal VM as small as possible. But rather, I don't want to put `#if INCLUDE_CDS` inside each of those functions that access a CDS-only feature. (E.g., `ConstantPoolCache::save_for_archive`, which accesses `_initial_entries`, which is declared only when CDS is enabled).

Thanks for the cleanup. One comment below.

src/hotspot/share/oops/method.cpp line 404:

> 402: }
> 403: 
> 404: #if INCLUDE_CDS

Do you need to ifdef out the declaration in method.hpp?

-------------

PR: https://git.openjdk.org/jdk/pull/10010


More information about the hotspot-dev mailing list