RFR: 8292891: ifdef-out some CDS-only functions [v2]

Ioi Lam iklam at openjdk.org
Fri Aug 26 04:45:33 UTC 2022


On Thu, 25 Aug 2022 11:42:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @calvinccheung comments
>
> src/hotspot/share/oops/klass.hpp line 575:
> 
>> 573:     }
>> 574:   }
>> 575: #endif
> 
> Can you add an // INCLUDE_CDS here?  If they're more than 10 lines apart, uncommented endifs can be really confusing.  This one is sort of borderline far away.  Thanks.

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10010


More information about the hotspot-dev mailing list