RFR: 8292921: Rewrite object field printer [v6]

Stefan Karlsson stefank at openjdk.org
Fri Aug 26 09:57:18 UTC 2022


On Fri, 26 Aug 2022 09:33:28 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalDefinitions.hpp line 95:
>> 
>>> 93: #define BOOL_TO_STR(_b_) ((_b_) ? "true" : "false")
>>> 94: 
>>> 95: // Format 8-bit quantities.
>> 
>> Maybe a little comment explaining the various suffixes?
>
> Sure

Added a comment. I see that there's some inconsistency, with the names used for SIZE_FORMAT_HEX. And we could probably replace PTR32_FORMAT/PTR64_FORMAT/INTPTRNZ_FORMAT, now that we have these new integer format specifiers. I'd like to do that cleanup as a separate patch.

-------------

PR: https://git.openjdk.org/jdk/pull/10028


More information about the hotspot-dev mailing list