RFR: 8292981: Unify and restructure integer printing format specifiers [v3]

Stefan Karlsson stefank at openjdk.org
Tue Aug 30 12:58:39 UTC 2022


On Mon, 29 Aug 2022 23:59:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use PTR_FORMAT in AIX code
>
> src/hotspot/share/utilities/globalDefinitions.hpp line 169:
> 
>> 167: #define PTR_FORMAT               "0x%08"      PRIxPTR
>> 168: #endif  // _LP64
>> 169: #define INTPTR_FORMAT_H_W(width) "%"   #width PRIxPTR
> 
> The naming of INTPTR_FORMAT_H_W is inconsistent with INTPTR_FORMAT.  It seems only used in one area of Shenandoah code, where it seems like they should be using PTR_FORMAT, except they are trying to output fewer leading zeros.  I'm somewhat inclined to say this doesn't belong in globalDefinitions.hpp at all; if they have specialized printing desirements they can define whatever they want themselves.

I've moved this to Shenandoah now.

-------------

PR: https://git.openjdk.org/jdk/pull/10042


More information about the hotspot-dev mailing list