RFR: 8292981: Unify and restructure integer printing format specifiers [v4]
Stefan Karlsson
stefank at openjdk.org
Tue Aug 30 17:25:14 UTC 2022
On Tue, 30 Aug 2022 15:59:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> I tried to describe it above:
>>
>> // _X - print as hexadecimal, without leading 0s: 0x12345
>> // _X_0 - print as hexadecimal, with leading 0s: 0x00012345
>>
>>
>> It's about padding with 0s. So, that you get 0x00012345 instead of 0x12345. Do you have a suggestion on how to write that comment any clearer?
>
> I see that now. I wandered into the diffs to quickly see what this is about and saw this without the comment and it looked strange. Maybe _0X would also look strange, or even _0_X. I assume these alternatives have been discussed and discarded.
They have not been discussed. I looked for a pragmatic solution to the problem that parts of the code have different formatting requirements, and then selected one naming convention that I liked. This can still be changed if we can agree on a another / better naming convention.
-------------
PR: https://git.openjdk.org/jdk/pull/10042
More information about the hotspot-dev
mailing list