RFR: 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv [v2]

Fei Yang fyang at openjdk.org
Wed Aug 31 01:26:06 UTC 2022


On Tue, 30 Aug 2022 07:40:47 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Cleanup MacroAssembler::movoop logic with respect to code patching on aarch64 and riscv.
>> 
>> Remove the `bool immediate` argument as it is only used with the value `true` in `void MacroAssembler::movoop(Register dst, jobject obj, bool immediate)`
>> 
>> Make comments and logic more clear and easier to read.
>> 
>> Testing: osx, linux aarch64 tier 1-3
>
> Axel Boldt-Christmas has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8293035
>  - 8293035: Cleanup MacroAssembler::movoop code patching logic aarch64 riscv

Updated changes look good to me. Also performed tier1 test on linux-riscv64 platform.

-------------

Marked as reviewed by fyang (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10065


More information about the hotspot-dev mailing list