RFR: 8292375: Convert ProtectionDomainCacheTable to ResourceHashtable [v4]

David Holmes dholmes at openjdk.org
Wed Aug 31 05:18:30 UTC 2022


On Tue, 30 Aug 2022 20:11:51 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/protectionDomainCache.hpp line 35:
>> 
>>> 33: // The amount of different protection domains used is typically magnitudes smaller
>>> 34: // than the number of system dictionary entries (loaded classes).
>>> 35: class ProtectionDomainCacheTable : public AllStatic {
>> 
>> How about adding a comment to say what this table maps from/to? Something like:
>> 
>> // The ProtectionDomainCacheTable maps all java.security.ProtectionDomain objects that are
>> // registered by DictionaryEntry::add_protection_domain() to a unique WeakHandle.
>
> Okay, I added your comment.

I still can't decipher what this "map" actually holds. What does the unique WeakHandle actually refer to?

-------------

PR: https://git.openjdk.org/jdk/pull/10043


More information about the hotspot-dev mailing list