RFR: 8293050: RISC-V: Remove redundant non-null assertions about macro-assembler

Aleksey Shipilev shade at openjdk.org
Wed Aug 31 09:08:22 UTC 2022


On Tue, 30 Aug 2022 11:12:30 GMT, Fei Yang <fyang at openjdk.org> wrote:

> There are some non-null assertions about macro-assembler in riscv-specific code. Most of them are there to make some internal code-check tools happy. We should remove those redundant assertions to make the code clean.
> 
> Tested with tier1 hotspot on linux-riscv64 unmatched.

Looks okay, but I wonder if we want to do the fence change separately.

src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 529:

> 527:   __ push(state);
> 528:   __ call_VM(noreg, runtime_entry);
> 529:   __ membar(MacroAssembler::AnyAny);

This does not look like a "redundant non-null assertion" :)

-------------

PR: https://git.openjdk.org/jdk/pull/10079


More information about the hotspot-dev mailing list