RFR: JDK-8296907: VMError: add optional callstacks, siginfo for secondary errors [v2]
Thomas Stuefe
stuefe at openjdk.org
Thu Dec 1 08:10:52 UTC 2022
On Mon, 14 Nov 2022 05:16:05 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update test/hotspot/jtreg/runtime/ErrorHandling/SecondaryErrorTest.java
>>
>> remove blank
>>
>> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> Seems reasonable in terms of the code, but I am curious how you expect this to be used in practice? If you get a secondary crash with this turned off then I would expect to use gdb on the core file to get the secondary stack, rather than using the new flag and hoping to reproduce the problem. To be useful it seems you would have to remember to run with this always enabled when developing/debugging. ??
@dholmes-ora do you have any objections to this? If you lack time, that is fine, then I try to get another reviewer.
-------------
PR: https://git.openjdk.org/jdk/pull/11118
More information about the hotspot-dev
mailing list