RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable
Coleen Phillimore
coleenp at openjdk.org
Thu Dec 1 09:37:46 UTC 2022
On Tue, 22 Nov 2022 14:48:11 GMT, Afshin Zafari <duke at openjdk.org> wrote:
> test of tier1-5 passed.
src/hotspot/share/prims/jvmtiTagMapTable.hpp line 41:
> 39: JvmtiTagMapEntry* next() const {
> 40: return (JvmtiTagMapEntry*)HashtableEntry<WeakHandle, mtServiceability>::next();
> 41: }
This should add a comment above JvmtiTagMapEntry that the entry is the key (could be renamed JvmtiTagMapKey). Also add a comment above that the oop is needed for lookup rather than creating a WeakHandle during lookup because the HeapWalker may walk soon to be dead objects and creating a WeakHandle for an otherwise dead object makes G1 unhappy.
-------------
PR: https://git.openjdk.org/jdk/pull/11288
More information about the hotspot-dev
mailing list