RFR: 8297864: Dead code elimination
Coleen Phillimore
coleenp at openjdk.org
Thu Dec 1 14:39:26 UTC 2022
On Wed, 30 Nov 2022 18:10:09 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Please consider removing all this dead code.
> I did not have any good way of splitting this up and I did not see any benefit is just splitting it up 'just because'.
> There is one commit per file couple.
> Not much else to say, passes t1-4 and I can build:
> linux-aarch64-debug,linux-arm32-debug,linux-ppc64le-debug,linux-s390x-debug,linux-x86,linux-x86-debug,macosx-aarch64-debug,macosx-x64,macosx-x64-debug,windows-x64-debug,windows-x86-debug and zero-x64-debug
> Some of them I also built release.
I agree, splitting this up would just waste time. Please run this tool more often! I see some things I should have removed in here, and some things that were proactively added can be added when there's code to use them.
Looks wonderful. Will make the code easier to maintain.
-------------
Marked as reviewed by coleenp (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11439
More information about the hotspot-dev
mailing list