RFR: JDK-8296907: VMError: add optional callstacks, siginfo for secondary errors [v11]

Thu Dec 1 16:21:52 UTC 2022

On Thu, 1 Dec 2022 15:51:28 GMT, Ralf Schmelter <rschmelter at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert accidental change
>
> src/hotspot/share/runtime/globals.hpp line 520:
> 
>> 518:           range(0, (uint64_t)max_jlong/1000)                                \
>> 519:                                                                             \
>> 520:   develop(bool, ErrorLogSecondaryErrorDetails, false,                       \
> 
> Making this a debug flag severely limits its usefulness. You would have to switch the VM to a debug VM, which might be hard for some customers. Since the change doesn't adds much code and there is no performance impact, I would make it diagnostic or product.

You convinced me. I will make it a diagnostic product flag, by default off.

-------------

PR: https://git.openjdk.org/jdk/pull/11118