RFR: JDK-8294902: Undefined Behavior in C2 regalloc with null references [v5]

Andrew Haley aph at openjdk.org
Thu Dec 1 17:25:35 UTC 2022


On Thu, 1 Dec 2022 17:21:45 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Please, initialize `_caller_jvms` to `NULL` (on line 47), switch the null check to `caller_jvms` (on line 60), and  move the assert under the null check.
>
> I'm sorry, I've been looking at this for a while, and I can't figure out what "move the assert under the null check" means. There are three asserts here, and two of them are under the `if (caller_jvms != NULL)` check.

> Please, initialize `_caller_jvms` to `NULL` (on line 47), switch the null check to `caller_jvms` (on line 60), a

Done.

-------------

PR: https://git.openjdk.org/jdk/pull/10920


More information about the hotspot-dev mailing list