RFR: 8297864: Dead code elimination [v2]

David Holmes dholmes at openjdk.org
Fri Dec 2 03:09:07 UTC 2022


On Thu, 1 Dec 2022 21:24:34 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Please consider removing all this dead code.
>> I did not have any good way of splitting this up and I did not see any benefit is just splitting it up 'just because'.
>> There is one commit per file couple.
>> Not much else to say, passes t1-4 and I can build:
>> linux-aarch64-debug,linux-arm32-debug,linux-ppc64le-debug,linux-s390x-debug,linux-x86,linux-x86-debug,macosx-aarch64-debug,macosx-x64,macosx-x64-debug,windows-x64-debug,windows-x86-debug and zero-x64-debug
>> Some of them I also built release.
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove code missed in a merge

Hmm I think this warrants closer inspection to ensure there isn't a bug because something is unused (e.g. `is_in_asgct()` code in forte.cpp).

Also IIRC Loom knowingly integrated a lot of code that will only come in to play in future previews and so it may not be appropriate to cull it now. Perhaps @pchilano can comment?

-------------

PR: https://git.openjdk.org/jdk/pull/11439


More information about the hotspot-dev mailing list