RFR: 8297967: Make frame::safe_for_sender safer [v2]

David Holmes dholmes at openjdk.org
Fri Dec 2 06:21:10 UTC 2022


On Thu, 1 Dec 2022 19:21:54 GMT, Johannes Bechberger <duke at openjdk.org> wrote:

>> Makes frame::safe_for_sender safer by using os::is_readable_pointer to check the location of the return address.
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Imrove fix, thanks Martin

Changes requested by dholmes (Reviewer).

src/hotspot/cpu/aarch64/frame_aarch64.cpp line 45:

> 43: #include "runtime/stubRoutines.hpp"
> 44: #include "vmreg_aarch64.inline.hpp"
> 45: #include "runtime/os.hpp"

Please keep the include files in sorted order.

src/hotspot/cpu/x86/frame_x86.cpp line 260:

> 258:   if (!thread->is_in_usable_stack((address)this->fp())) {
> 259:     return false;
> 260:   }

This looks like a paste error - you've deleted a line that is needed and now you have two comment lines.

-------------

PR: https://git.openjdk.org/jdk/pull/11461


More information about the hotspot-dev mailing list