RFR: 8157023: Integrate NMT with JFR
Thomas Stuefe
stuefe at openjdk.org
Fri Dec 2 14:50:00 UTC 2022
On Fri, 2 Dec 2022 08:30:11 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> src/hotspot/share/services/memReporter.cpp line 25:
>>
>>> 23: */
>>> 24: #include "precompiled.hpp"
>>> 25: #include "jfr/jfrEvents.hpp"
>>
>> I think this is an intermixing of layers. I think it would be cleaner if if JFR accessed the current values from outside, instead of JFR knowledge leaking into NMT.
>
> Not sure I agree, I see the `MemReporter` as the reporting layer and it now knows about JFR to be able to report through it.
>
> We have in other places created small helpers that send the events to avoid including `jfrEvents.hpp` all over the place, and we could to that here as well. But I don't see a problem with having the reporter residing along side the other reporters.
Okay.
-------------
PR: https://git.openjdk.org/jdk/pull/11449
More information about the hotspot-dev
mailing list