RFR: JDK-8294902: Undefined Behavior in C2 regalloc with null references [v6]

Aleksey Shipilev shade at openjdk.org
Fri Dec 2 18:27:13 UTC 2022


On Fri, 2 Dec 2022 10:58:26 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/share/opto/postaloc.cpp line 259:
>> 
>>> 257:   if (!can_change_regs) {
>>> 258:     return blk_adjust;          // Only check stupid copies!
>>> 259:   }
>> 
>> Style nit here and in other places: weren't these blocks separated by newline before?
>
> I'm not sure what you mean. Can you make these Suggestions? Thanks.

See suggestions. I think the style is to have: 


  // Comment
  if (do_something) {
    some_code_here()
  }

  // Comment
  ...

-------------

PR: https://git.openjdk.org/jdk/pull/10920


More information about the hotspot-dev mailing list