RFR: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects [v2]

Leo Korinth lkorinth at openjdk.org
Mon Dec 5 13:00:47 UTC 2022


On Mon, 5 Dec 2022 11:05:02 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - growable stacked
>>  - Revert "working!"
>>    
>>    This reverts commit 5366f22c7202eaa2182976c084d02e9af4f56de0.
>
> src/hotspot/share/utilities/concurrentHashTable.inline.hpp line 993:
> 
>> 991:   Node* const volatile * rem_n_prev = bucket->first_ptr();
>> 992:   Node* rem_n = bucket->first();
>> 993:   for (dels = 0; rem_n != nullptr; ++dels) {
> 
> `dels` is incremented even when `eval_f(rem_n->value())` is false. This means that the return value may be overcounting, and there will be uninitialized pointer values in the `ndel` array.

Thanks! that was bad from my part :-(

-------------

PR: https://git.openjdk.org/jdk/pull/10983


More information about the hotspot-dev mailing list