RFR: 8297729: Replace GrowableArray in ComputeMoveOrder with hash table [v4]
Johan Sjölen
jsjolen at openjdk.org
Mon Dec 5 18:01:17 UTC 2022
On Mon, 5 Dec 2022 17:48:18 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
>> Replaces the GrowableArray 'table' in ComputeMoveOrder with a real hash table.
>>
>> Through testing, I found that sometimes this array is blown up to several thousand elements, most of which are `NULL`. Using a hash table prevents this large wastage.
>>
>> I've touched up some of the surrounding code as well. Mostly style changes, but I've also removed the `BasicType` field from the `Move` and `MoveOperation` structs, since it was unused, and added frame data storages to the fast path for stack args as well, since both are allocated on the stack.
>>
>> Testing: `jdk_foreign` test suite.
>
> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>
> Use specialized equals function
Looks good, thank you for the changes.
-------------
Marked as reviewed by jsjolen (Committer).
PR: https://git.openjdk.org/jdk/pull/11392
More information about the hotspot-dev
mailing list