RFR: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects [v2]

Leo Korinth lkorinth at openjdk.org
Tue Dec 6 09:00:07 UTC 2022


On Mon, 5 Dec 2022 10:39:45 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - growable stacked
>>  - Revert "working!"
>>    
>>    This reverts commit 5366f22c7202eaa2182976c084d02e9af4f56de0.
>
> src/hotspot/share/utilities/concurrentHashTable.inline.hpp line 524:
> 
>> 522:     }
>> 523:     for (size_t node_it = 0; node_it < nd; node_it++) {
>> 524:       Node* ndel = node_it < BULK_DELETE_LIMIT ? ndel_stack[node_it] : extra.at(node_it - BULK_DELETE_LIMIT);
> 
> Needs to be a reference (`Node*& ndel`) or `DEBUG_ONLY(ndel = (Node*)POISON_PTR;)` will be a no-op.

Will fix, thanks!

-------------

PR: https://git.openjdk.org/jdk/pull/10983


More information about the hotspot-dev mailing list