RFR: 8157023: Integrate NMT with JFR [v3]

Stefan Johansson sjohanss at openjdk.org
Tue Dec 6 14:00:47 UTC 2022


On Tue, 6 Dec 2022 12:47:13 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Special snapshot for NMT events in JFR
>
> src/hotspot/share/services/memSnapshot.hpp line 42:
> 
>> 40: };
>> 41: 
>> 42: class MemSnapshot : public CHeapObj<mtNMT> {
> 
> Can we name this not Snapshot but something different? We already have MallocMemorySnapshot and methods like "as_snapshot", which have nothing to do with this layer.
> 
> proposals:
> 
> `NMTData`
> `NMTStatistics`
> `NMTStatSet`
> 
> .... 
> ....

I assume you don't think `NMTSnapshot` is good much better =) I can't come up with something much better than your suggestions, `NMTUsage` is not perfect either (sound like the usage cause by NMT). If we don't go with the NMT-prefix I think something like `MemUsage`or `NativeMemoryUsage` would make sense. Looking at the other reporting classes connected to NMT they are named `Mem`-something. So I think `MemUsage`, what do you think?

-------------

PR: https://git.openjdk.org/jdk/pull/11449


More information about the hotspot-dev mailing list