RFR: 8157023: Integrate NMT with JFR [v2]
Thomas Stuefe
stuefe at openjdk.org
Tue Dec 6 15:36:07 UTC 2022
On Mon, 5 Dec 2022 13:49:55 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Stefan Johansson has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Some refactoring after comments
>> - egahlin and carterkozak comments
>
> Looks good. Small simplification, instead of "_has_xxx" boolean flags, just use your MemSnapshotOptions as member.
> Another thing @tstuefe, have you double checked my accounting around `mtChunk`? I tried to mimic what's done for the baseline and normal print-reports. Looks correct?
Forget my last comment about mtChunk. I think what you do is correct.
-------------
PR: https://git.openjdk.org/jdk/pull/11449
More information about the hotspot-dev
mailing list