RFR: JDK-8298084: Memory leak in Method::build_profiling_method_data

[Justin King]

On Wed, 7 Dec 2022 08:28:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

> I see how [JDK-8297389](https://bugs.openjdk.org/browse/JDK-8297389) caused this now but am unclear how to truly fix it. The memory management aspects of all this are extremely convoluted. In the context of [JDK-8297389](https://bugs.openjdk.org/browse/JDK-8297389) if it needs to free a MethodData that it allocated, then I would expect that to be a complete freeing - not sure why it doesn't call the destructor to handle things as that is what the destructor is for.

IMO the destructor should just be called from MetadataFactory::free_metadata before returning the memory to the underlying arena. That way the destructor is the last thing called and not accessed again. Destructors mark the end of the objects lifetime.

-------------

PR: https://git.openjdk.org/jdk/pull/11526