RFR: 8296401: ConcurrentHashTable::bulk_delete might miss to delete some objects

Ivan Walulya iwalulya at openjdk.org
Wed Dec 7 10:30:29 UTC 2022


On Tue, 6 Dec 2022 13:42:47 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> > > That is true. Do you think that is a problem with the new implementation?
> > > The change overrides the intentions of `BULK_DELETE_LIMIT ` so it would be better to change the name of that constant.
> 
> Is `STACK_BUFFER_SIZE` good enough, or do you have a better suggestion? I would also prefer to make it look less like a C macro and use the alternative casing `StackBufferSize`, is that OK?

The name is fine by me, however, you need a comment to motivate the use of the stack array instead of a growable array right away

-------------

PR: https://git.openjdk.org/jdk/pull/10983


More information about the hotspot-dev mailing list