RFR: 8298099: [JVMCI] decouple libgraal from JVMCI module at runtime [v5]

Alan Bateman alanb at openjdk.org
Wed Dec 7 18:47:04 UTC 2022


On Tue, 6 Dec 2022 15:44:04 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/vm/TranslatedException.java line 44:
>> 
>>> 42:  */
>>> 43: @SuppressWarnings("serial")
>>> 44: final class TranslatedException extends Exception {
>> 
>> Would it be possible to re-format this to avoid the wildly long (150+) lines? This seems to be moving jdk.vm.ci.hotspot.TranslatedException and hard to see what is going on.
>
> Is there some tool support for formatting Java source code to meet OpenJDK coding guidelines? Rather unfortunate that one has to do this manually and reviewers have to spend time manually checking it.

There isn't a code or agreed conventions. The cleanup in the latest version looks okay.

-------------

PR: https://git.openjdk.org/jdk/pull/11513


More information about the hotspot-dev mailing list