RFR: JDK-8298084: Memory leak in Method::build_profiling_method_data

[Coleen Phillimore]

On Tue, 6 Dec 2022 06:13:23 GMT, Justin King <jcking at openjdk.org> wrote:

> Resolve memory leak related to `MethodData::_extra_data_lock` in `Method::build_profiling_method_data` by defining `MethodData::release_C_heap_structures` and calling it where appropriate before deallocating `MethodData`.

No, do not make MetadataFactory::free_metadata call the destructor.  It might break other metadata that is passed to it.  It would require special consideration and redo the whole design of the thing.  Yes, the memory management is convoluted here.
The release_C_heap_structures() call is the right thing to do here.

-------------

PR: https://git.openjdk.org/jdk/pull/11526