RFR: 8292674: ReportJNIFatalError should print all java frames

Patricio Chilano Mateo pchilanomate at openjdk.org
Wed Dec 7 21:07:12 UTC 2022


On Wed, 7 Dec 2022 20:39:48 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/jni/checked/TestPrimitiveArrayCriticalWithBadParam.java line 32:
>> 
>>> 30:  * @comment Tests reporting with regular thread and virtual thread.
>>> 31:  * @library /test/lib
>>> 32:  * @enablePreview
>> 
>> Don't we need @requires vm.continuations also? I remember having failures on the linux-x86 tests because of this, but don't see those runs in your Github actions to double check.
>
>> Don't we need @requires vm.continuations also? I remember having failures on the linux-x86 tests because of this, but don't see those runs in your Github actions to double check.
> 
> You can quickly test this by running the test with -XX:-VMContinuations rather than waiting for GHA. I suspect it should pass as this test is just checking for the "FATAL ERROR" and bad param strings so should be okay with the alt implementation of virtual threads used on x86_32 and other platforms without a port.

Thanks for the tip @AlanBateman. I run it with -XX:-VMContinuations and verified it works.

-------------

PR: https://git.openjdk.org/jdk/pull/11503


More information about the hotspot-dev mailing list