RFR: JDK-8298084: Memory leak in Method::build_profiling_method_data [v4]

David Holmes dholmes at openjdk.org
Thu Dec 8 06:32:04 UTC 2022


On Thu, 8 Dec 2022 06:14:48 GMT, Justin King <jcking at openjdk.org> wrote:

>> Resolve memory leak related to `MethodData::_extra_data_lock` in `Method::build_profiling_method_data` by calling `MethodData::~MethodData()`.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update include order to be alphabetical
>   
>   Signed-off-by: Justin King <jcking at google.com>

src/hotspot/share/memory/metadataFactory.hpp line 77:

> 75:       if (invoke_destructor) {
> 76:         using U = typename RemoveCV<typename RemovePointer<T>::type>::type;
> 77:         md->~U();

I was actually thinking of a template specialization for MethodData, but I guess this works. Lets see what others think.

-------------

PR: https://git.openjdk.org/jdk/pull/11526


More information about the hotspot-dev mailing list