RFR: 8298377: JfrVframeStream causes deadlocks in ZGC
Stefan Karlsson
stefank at openjdk.org
Thu Dec 8 11:31:49 UTC 2022
The JfrVFrameStream is used while generating stack traces for events. One of the events are the ZPage allocation event. This event is sometimes sent when ZGC is relocating. The current implementation of JfrVFrameStream uses WalkContinuation::include, which causes JFR to walk the continuation and perform GC barriers. This is problematic, since ZGC has a requirement that we never perform load barriers while running the relocation code. If we do, we might end up performing other reloctions from the the relocation code, and in some cases that causes dead locks.
I propose that JFR doesn't walk the continuations when sending events. An alternative could be to limit this to ZGC, but I'd like to get some feedback around that from JFR / Loom devs.
We've been testing this patch in the Generational ZGC repository.
-------------
Commit messages:
- 8298377: JfrVframeStream causes deadlocks in ZGC
Changes: https://git.openjdk.org/jdk/pull/11586/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11586&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8298377
Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/11586.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11586/head:pull/11586
PR: https://git.openjdk.org/jdk/pull/11586
More information about the hotspot-dev
mailing list