RFR: JDK-8298084: Memory leak in Method::build_profiling_method_data [v6]

Justin King jcking at openjdk.org
Fri Dec 9 12:39:54 UTC 2022


On Thu, 8 Dec 2022 08:19:26 GMT, Justin King <jcking at openjdk.org> wrote:

>> Resolve memory leak related to `MethodData::_extra_data_lock` in `Method::build_profiling_method_data` by calling `MethodData::~MethodData()`.
>
> Justin King has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comment to metaprogramming usage
>   
>   Signed-off-by: Justin King <jcking at google.com>

Sure, no problem! Will be faster that way. Feel free to tag the other issue
related to convoluted memory management. Maybe dropping that comment in
related code and resolving it. Awkward but well documented is just as good.

On Fri, Dec 9, 2022, 5:54 PM Coleen Phillimore ***@***.***>
wrote:

> I want to take over this fix and I will rebase it to JDK 20. Sorry for
> being so late to remembering how this code works. The LSan tool sounds
> great. I'll pay attention to that now.
>
>> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/jdk/pull/11526#issuecomment-1344243663>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAHTURQDPA544PWCOYWEFXDWMMQG7ANCNFSM6AAAAAASVDQ4QQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>

-------------

PR: https://git.openjdk.org/jdk/pull/11526


More information about the hotspot-dev mailing list