RFR: JDK-8294902: Undefined Behavior in C2 regalloc with null references [v8]

Andrew Haley aph at openjdk.org
Mon Dec 12 14:12:19 UTC 2022


> This patch fixes the remaining null pointer dereference bugs that I know of.
> 
> For the main bug, C2 was using a null reference to indicate an uninitialized `Node_List`. I replaced the null reference with a static sentinel.
> 
> I also turned on `-fsanitize=null` and found and fixed a bunch of other null pointer dereferences. With this,I have run a full bootstrap and tier1 tests with `-fsanitize=null` enabled.
> 
> I have checked that the code generated by GCC is not worse in any significant way, so I don't expect to see any performance regressions.
> 
> I'd like to enable `-fsanitize=null` in debug builds to prevent regressions in this area. What do you think?

Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:

  Reviewer feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10920/files
  - new: https://git.openjdk.org/jdk/pull/10920/files/429a6300..812ce8fc

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10920&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10920&range=06-07

  Stats: 7 lines in 2 files changed: 1 ins; 3 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/10920.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10920/head:pull/10920

PR: https://git.openjdk.org/jdk/pull/10920


More information about the hotspot-dev mailing list