RFR: JDK-8294902: Undefined Behavior in C2 regalloc with null references [v13]

Andrew Haley aph at openjdk.org
Mon Dec 12 18:27:34 UTC 2022


On Mon, 12 Dec 2022 18:20:03 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'JDK-8294902' of https://github.com/theRealAph/jdk into JDK-8294902
>>  - Reviewer feedback
>
> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 178:
> 
>> 176: // Converts any type T to a reference type.
>> 177: template<typename T>
>> 178: std::add_rvalue_reference_t<T> declval() noexcept;
> 
> Why is this in the gcc-specific file?  How can this even work? The use in vmStructs.cpp is in shared code.

Oh, I pushed an incomplete change, sorry. I'm done now.

-------------

PR: https://git.openjdk.org/jdk/pull/10920


More information about the hotspot-dev mailing list