[jdk20] RFR: 8298084: Memory leak in Method::build_profiling_method_data [v3]

Coleen Phillimore coleenp at openjdk.org
Tue Dec 13 02:26:22 UTC 2022


On Tue, 13 Dec 2022 01:15:18 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Even more metaprogramming improvements
>
> src/hotspot/share/oops/instanceKlass.cpp line 600:
> 
>> 598:   // Can't release the constant pool here because the constant pool can be
>> 599:   // deallocated separately from the InstanceKlass for default methods and
>> 600:   // redefine classes.
> 
> Does this comment make sense when the parameter doesn't actually control release of the CP?

It should be inclusive of MethodData also.

-------------

PR: https://git.openjdk.org/jdk20/pull/13


More information about the hotspot-dev mailing list