RFR: 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug
Afshin Zafari
duke at openjdk.org
Fri Dec 16 08:04:52 UTC 2022
### Description
The following problems found and solved:
1) Reporting which regex pattern did not match with error messages was incorrect. To report the mismatched pattern, the head of the pattern list was peeked, while it was the already peeked item from that did not match. So the next pattern to the mismatched one was reported.
2) The pattern for finding a crash was incorrectly set to "# .*VMError::controlled_crash.*", while it has to be "# .*crash_with_segfault.*".
3) `crash_with_segfault` function is too small and was `inline`d in compiler optimisations. So it was not in the stack trace when the error message is created.
### Patch
1 and 2 corrected and added the `NOINLINE` to the `crash_with_segfault` signature. The same applied for `crash_with_sigfpe` function.
### Test
runtime/ErrorHandling/* and tier1-5
-------------
Commit messages:
- Merge branch 'master' into _8298128
- 8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug
Changes: https://git.openjdk.org/jdk/pull/11704/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11704&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8298128
Stats: 14 lines in 4 files changed: 8 ins; 0 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/11704.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11704/head:pull/11704
PR: https://git.openjdk.org/jdk/pull/11704
More information about the hotspot-dev
mailing list