RFR: 8295661: CompileTask::compile_id() should be passed as int

Damon Fenacci duke at openjdk.org
Fri Dec 16 09:39:17 UTC 2022


Changed return type of `CompileTask::compile_id()` from `int` to `uint`.
Also modified the type everywhere `compile_id` is used (parameters, local variables, string formatting, constant assignments) *as much as possible*.
Added *asserts* to check for valid value range where not possible.

-------------

Commit messages:
 - JDK-8295661 correct indentation and update copyright year
 - JDK-8295661 change type of _compile_id field from uint to int and fix all inconsistencies (make al compile IDs int)
 - Revert "JDK-8295661: CompileTask::compile_id() should return uint instead of int"
 - Revert "JDK-8295661 fix assert conditions"
 - Revert "JDK-8295661 fix indentation/white spaces"
 - Revert "JDK-8295661 revert wrong parameter name change"
 - Revert "JDK-8295661 update copyright date"
 - Revert "Update src/hotspot/share/c1/c1_Compilation.cpp"
 - Revert "JDK-8295661 review fixes"
 - JDK-8295661 review fixes
 - ... and 6 more: https://git.openjdk.org/jdk/compare/a37de62d...b9111ef5

Changes: https://git.openjdk.org/jdk/pull/11630/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11630&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295661
  Stats: 47 lines in 9 files changed: 0 ins; 2 del; 45 mod
  Patch: https://git.openjdk.org/jdk/pull/11630.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11630/head:pull/11630

PR: https://git.openjdk.org/jdk/pull/11630


More information about the hotspot-dev mailing list