RFR: 8295661: CompileTask::compile_id() should be passed as int

Doug Simon dnsimon at openjdk.org
Fri Dec 16 09:39:19 UTC 2022


On Mon, 12 Dec 2022 13:35:26 GMT, Damon Fenacci <duke at openjdk.org> wrote:

>> src/hotspot/share/jvmci/jvmciEnv.cpp line 1625:
>> 
>>> 1623:   if (cb == (CodeBlob*) code) {
>>> 1624:     nmethod* nm = cb->as_nmethod_or_null();
>>> 1625:     assert(compile_id_snapshot >= 0, "negative compile id snapshot");
>> 
>> That's something to check with the JVMCI experts but I'm wondering why `compile_id_snapshot` is a jlong whereas the compile id is a jint.
>
> OK. Strange indeed!

It's a good question and unfortunately I cannot recall the reason. Maybe @tkrodriguez can. In any case, I don't think it impacts this change.

-------------

PR: https://git.openjdk.org/jdk/pull/11630


More information about the hotspot-dev mailing list