RFR: 8292170: Convert CodeRootSetTable to use ResourceHashtable [v3]

Leo Korinth lkorinth at openjdk.org
Fri Dec 16 12:47:48 UTC 2022


On Thu, 15 Dec 2022 16:19:37 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> I am replacing the old hash table with ResourceHashtable. In the process I am also removing the redundant `_length` field. By removing the `_length` field, a lot of asserts can be removed as the length will trivially match the length of the underlying table.
>> 
>> I would like to have feedback on the addition of `unlink_destruct(Function&& should_remove)`. I added it because I prefer to use a functor object that can be used by lambdas instead of an iterator object. However, I did add code to "destruct" resource objects when they are removed instead of just letting them be to reflect that we use `delete` on c-heap objects. Maybe I should remove this "improvement" and then maybe implement the function by calling the existing unlink?
>
> Leo Korinth has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - remove specialized hash
>  - inline g1CodeRootSetTable.hpp
>  - remove unused template

Ivan has found a test error, and it looks like I have a bug.

-------------

PR: https://git.openjdk.org/jdk/pull/11675


More information about the hotspot-dev mailing list