RFR: 8295661: CompileTask::compile_id() should be passed as int

Damon Fenacci duke at openjdk.org
Mon Dec 19 08:47:54 UTC 2022


On Tue, 13 Dec 2022 16:57:29 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Changed return type of `CompileTask::compile_id()` from `int` to `uint`.
>> Also modified the type everywhere `compile_id` is used (parameters, local variables, string formatting, constant assignments) *as much as possible*.
>> Added *asserts* to check for valid value range where not possible.
>
> Thanks Tom. The intention of this change was mainly consistency, not avoiding a potential overflow.

@TobiHartmann @tkrodriguez @dougxc thanks for your reviews.

-------------

PR: https://git.openjdk.org/jdk/pull/11630


More information about the hotspot-dev mailing list