RFR: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames

[David Holmes]

On Wed, 21 Dec 2022 08:39:55 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> If a JNI Fatal error, or a JNI warning (from Xcheck:jni) is triggered in "top-level" native code (such as the launcher itself, or a freshly attached native thread) then there is no stack printed as there are no Java frames. This enhancement changes that so that we print the native stack, similarly to how error reporting does. We reuse VMError::print_native _stack to do this, but it could be argued this should be moved to a more general purpose utility class - suggestions welcome.
>> 
>> Testing:
>>   - manual fault injection (see bug report)
>>   - tiers 1-4
>> 
>> Thanks.
>
> Yes, the stack-walking code spread out in different places, we should make an effort here.
> 
> Looks good, thank!

Thanks for the review @robehn . I will file a RFE to consolidate the different native stack walking related code.

-------------

PR: https://git.openjdk.org/jdk/pull/11703