RFR: 8250269: Replace ATTRIBUTE_ALIGNED with alignas [v5]

Julian Waters jwaters at openjdk.org
Thu Dec 22 04:51:27 UTC 2022


> C++11 added the alignas attribute, for the purpose of specifying alignment on types, much like compiler specific syntax such as gcc's __attribute__((aligned(x))) or Visual C++'s __declspec(align(x)).
> 
> We can phase out the use of the macro in favor of the standard attribute. In the meantime, we can replace the toolchain specific definitions of ATTRIBUTE_ALIGNED with a portable definition. We might deprecate the use of the macro but changing its implementation quickly and cleanly applies the feature where the macro is being used.
> 
> Note: With certain parts of HotSpot using ATTRIBUTE_ALIGNED so indiscriminately, this commit will likely take some time to get right
> 
> This will require adding the alignas attribute to the list of language features approved for use in HotSpot code. (Ongoing at [8297912](https://github.com/openjdk/jdk/pull/11446))

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - Merge branch 'openjdk:master' into alignas
 - Merge branch 'openjdk:master' into alignas
 - Merge branch 'openjdk:master' into alignas
 - alignas

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11431/files
  - new: https://git.openjdk.org/jdk/pull/11431/files/1d69a46f..3f3a3625

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11431&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11431&range=03-04

  Stats: 5442 lines in 254 files changed: 3263 ins; 990 del; 1189 mod
  Patch: https://git.openjdk.org/jdk/pull/11431.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11431/head:pull/11431

PR: https://git.openjdk.org/jdk/pull/11431


More information about the hotspot-dev mailing list