RFR: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu Dec 22 21:12:54 UTC 2022
On Thu, 22 Dec 2022 15:00:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added a regression test
>
> test/hotspot/jtreg/runtime/jni/nativeStack/TestNativeStack.java line 65:
>
>> 63: "TestNativeStack$Main",
>> 64: "error");
>> 65: oa.reportDiagnosticSummary();
>
> So this just prints out the stack trace but doesn't do a shouldContain or some verification of the elements? I presume because this would be unreliable? This seems ok, but just checking. I think it's still worth having a regression test because this looked hard to write and if the stack in the messages do disappear, it'll save someone from having to rewrite this.
Oh, that's much better!
-------------
PR: https://git.openjdk.org/jdk/pull/11703
More information about the hotspot-dev
mailing list