RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v4]

[Serguei Spitsyn]

On Thu, 22 Dec 2022 22:06:19 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

> Hi Serguei,
> 
> Some comments on the changes below.
> 
> Thanks, Patricio

Thank you for reviewing it, Patricio!

> src/hotspot/share/prims/jvmtiThreadState.cpp line 310:
> 
>> 308:     ml.wait(10); // wait while there is an active suspender or resumer
>> 309:   }
>> 310:   Atomic::inc(&_VTMS_transition_disable_for_one_count);
> 
> I don't understand the purpose of this counter. We only seem to write to it and the only place where it is checked is to do a notify, but I don't see a corresponding check-and-wait on that counter somewhere else, as we do with _VTMS_transition_disable_for_all_count.

Good catch.

> Hi Serguei,
> 
> Some comments on the changes below.
> 
> Thanks, Patricio

Thank you for reviewing it, Patricio!

-------------

PR: https://git.openjdk.org/jdk/pull/11690