RFR: 8214976: Warn about uses of functions replaced for portability [v2]

[Harold Seigel]

On Sat, 29 Jan 2022 07:09:18 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> We only compile AIX with xclang these days.  I don't know how our "xlc" compiler platform mechanism interacts with our "gcc" (which is really both gcc and clang) compiler platform, or if it interacts, or if it should.  But none of that matters for the dirent.h problem.  The problem there is that it's a system header, irrespective of what compiler is being used, and it has this problem.  So whether we need this NULL cruft here depends on whether AIX with xclang uses this file or not.  One option would be to just not deal with the dirent stuff yet, saving that for a followup focused on that problem.
>
> Sorry, I'm confused. We build AIX with xlc. I don't believe we even include this file on AIX. How does this help AIX?

I removed the changes for the dirent functions and removed the above code.  I also reverted all changes to os_aix.cpp.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7248